Refactor operator tests #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbalcomb
added
change: feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simply refactors the various operator tests.
Now that the operators all have an example implementation the operator-specific tests with custom implementations are no longer necessary. The imports for the
Addmutator tests use the fully qualified path to the error type which is redundant and various tests names are inconsistent.This change removes the redundant tests, updates the imports, and renames the tests for consistency. This only affects tests and has no public change to the API. The
Recombineselector still needs to be updated to remove the custom selector but that depends on adding new composition selectors.