test(bendpoints): verifying that side effect do not occur#979
Open
AdamBanham wants to merge 1 commit intobpmn-io:developfrom
Open
test(bendpoints): verifying that side effect do not occur#979AdamBanham wants to merge 1 commit intobpmn-io:developfrom
AdamBanham wants to merge 1 commit intobpmn-io:developfrom
Conversation
Adds testing for the issue presented in bpmn-io#965. But I cannot recapture the report behaviour in the issue outside testing for the root svg element (which fails on develop without the fix from bpmn-io#976). But for element.out on shapes I was unable to trigger the same occurrences, perhaps due to the mock setup. Even when I copy the exact workings from the codepen :/
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Adds testing for the issue presented in #965.
But I cannot recapture all reported behaviour in #965.
Testing on root svg element (which fails on develop without the fix from #978) works.
But for element.out on shapes I was unable to trigger the same occurrences, perhaps due to the mock setup.
Even when I copy the exact workings from the codepen :/
If maintainers could take a look at how I am triggering the interaction events for shapes and ensure that my approach is suitable within the mock setup that would be great.
Related to #965
Related to #978
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}