Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made it more modern #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

made it more modern #1

wants to merge 1 commit into from

Conversation

load1n9
Copy link

@load1n9 load1n9 commented May 15, 2020

No description provided.

@torralbaa
Copy link
Member

This is a joke. True?

@torralbaa torralbaa added enhancement New feature or request invalid This doesn't seem right labels May 15, 2020
@load1n9
Copy link
Author

load1n9 commented May 15, 2020

absolutely don't worry

@torralbaa
Copy link
Member

Ok!

@tumble1999 tumble1999 added the good first issue Good for newcomers label May 15, 2020
@torralbaa torralbaa self-requested a review May 22, 2020 20:32
torralbaa
torralbaa reviewed May 22, 2020
View reviewed changes
Copy link
Member

@torralbaa torralbaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seems right. I'm not sure if it is valid TypeScript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torralbaa torralbaa torralbaa left review comments

@tumble1999 tumble1999 tumble1999 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@load1n9 @torralbaa @tumble1999