Update documentation for Passing data into expressions #2928
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendudson
reviewed
Jun 26, 2024
| .set("shear", shear[i])); | ||
|
|
||
| BOUT_FOR(i, viscosity.getRegion("RGN_ALL")) { | ||
| viscosity[i] = gen->generate(bout::generator::Context().set("shear", shear[i])); |
Contributor
There was a problem hiding this comment.
This will use the default Context() constructor (https://github.com/boutproject/BOUT-dev/blob/master/include/bout/sys/generator_context.hxx#L19) so "x", "y", "z", "t" will not be defined. Recommend instead using the original Context(i, CELL_CENTRE, mesh, 0.0)
dschwoerer
reviewed
Aug 19, 2024
Comment on lines
-342
to
-346
| Note that the ``Context`` constructor takes the index, the cell | ||
| location (e.g. staggered), a mesh, and then the time (set to 0.0 | ||
| here). Additional variables can be ``set``, "shear" in this case. In | ||
| the input options file (or command line) the viscosity could now be a | ||
| function of ``{shear}`` |
Contributor
There was a problem hiding this comment.
@tbody-cfs any reason why this has been deleted?
dschwoerer
requested changes
Aug 19, 2024
Contributor
dschwoerer
left a comment
dschwoerer
left a comment
There was a problem hiding this comment.
See also Ben's comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates docs to match BOUT version used by Hermes-3 master (7d261d4)