feat: add MPS GPU sharing settings model #107
Open
+137
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add NvidiaMpsSettings struct and Mps variant to NvidiaDeviceSharingStrategy for NVIDIA Multi-Process Service support. Includes validation to prevent MPS and MIG from being enabled simultaneously. Signed-off-by: Matthew Yeazel <[email protected]>
piyush-jena
approved these changes
Jan 2, 2026
Contributor
piyush-jena
left a comment
piyush-jena
left a comment
There was a problem hiding this comment.
LGTM apart from the nitpicky request for an additional unit test. Nice work coding the conflict between MIG and MPS.
| let test_json = r#"{"nvidia":{"pass-device-specs":true,"device-id-strategy":"index","device-list-strategy":"volume-mounts","device-sharing-strategy":"mps","mps":{"replicas":4},"device-partitioning-strategy":"none"}}"#; | ||
|
|
||
| let device_plugins: KubeletDevicePluginsV1 = serde_json::from_str(test_json).unwrap(); | ||
| assert_eq!( |
Contributor
There was a problem hiding this comment.
Can you add an assert for replicas? and an unit test for the default number of replicas = 2?
bcressey
reviewed
Jan 9, 2026
Comment on lines
+27
to
+29
| // Define the bounds for the `mps.replicas` field | ||
| const MPS_REPLICAS_MIN: i32 = 2; | ||
| const MPS_REPLICAS_MAX: i32 = i32::MAX; |
Contributor
There was a problem hiding this comment.
These are actual bounds? It's not possible to set only one replica, and the software is fine with 2 billion replicas?
Comment on lines
+44
to
+58
| fn validate(value: Self, _validated_settings: Option<serde_json::Value>) -> Result<()> { | ||
| // Validate MPS and MIG are not both enabled | ||
| if let Some(ref nvidia) = value.nvidia { | ||
| let is_mps = matches!( | ||
| nvidia.device_sharing_strategy, | ||
| Some(NvidiaDeviceSharingStrategy::Mps) | ||
| ); | ||
| let is_mig = matches!( | ||
| nvidia.device_partitioning_strategy, | ||
| Some(NvidiaDevicePartitioningStrategy::MIG) | ||
| ); | ||
| if is_mps && is_mig { | ||
| return Err(KubeletDevicePluginsError::MpsMigConflict); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Does this validation logic actually work? AFAIK it's the first time we're attempting this sort of cross-setting validation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: bottlerocket-os/bottlerocket#4673
Description of changes:
Add NvidiaMpsSettings struct and Mps variant to NvidiaDeviceSharingStrategy for NVIDIA Multi-Process Service support. Includes validation to prevent MPS and MIG from being enabled simultaneously.
Testing:
The testing was documented in the related PR: bottlerocket-os/bottlerocket-core-kit#789
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.