Skip to content

Support multi-language agents #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ofelt
Copy link

@ofelt ofelt commented Oct 11, 2017

The module now supports multiple agents and different languages for each one.
It will now query an agent based on the locale of the user or the fallback language.
The config has changed to handle multiple agents, as such API_TOKEN is now depreciated.

Calling getAvailableLang and getAgent for each query seems a bit redundant but I don't know if there is another way to do it with how things works currently, suggestions welcome ^^

The module now supports multiple agents and different languages for each one.
It will now query an agent based on the locale of the user or the fallback language.
The config has changed to handle multiple agents, as such API_TOKEN is now depreciated.
Copy link
Member

@slvnperron slvnperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Oli for the awesome PR. The code looks good, we still have to test it internally on some existing bots to make sure it doesn't break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants