fix(packs): use manifest names for built-in packs#65
Open
iuyua9 wants to merge 1 commit intobotingw:mainfrom
Open
fix(packs): use manifest names for built-in packs#65iuyua9 wants to merge 1 commit intobotingw:mainfrom
iuyua9 wants to merge 1 commit intobotingw:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manifest.yamlnameas the public pack idno-memory-interaction-rulespackWhy
src/rulebook_ai/packs/no_memory_interation_rules/manifest.yamldeclares the pack name asno-memory-interaction-rules, butrulebook-ai packs listcurrently shows the misspelled directory name andrulebook-ai packs add no-memory-interaction-rulescannot resolve it. This makes the CLI expose an implementation detail instead of the pack identity declared by the manifest.Context checked:
CONTRIBUTING.md,src/rulebook_ai/core.py, and the existing pack integration tests.Tests
uv run --extra dev pytest tests/integration/test_packs_list.py tests/integration/test_packs_add.py -q