Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table Factor Fixes #1960

Merged
merged 5 commits into from
Jan 2, 2025
Merged

Table Factor Fixes #1960

merged 5 commits into from
Jan 2, 2025

Conversation

varunagrawal
Copy link
Collaborator

  1. Fixed a bug where a DecisionTreeFactor with reverse ordering of keys would cause incorrect table construction.
  2. Fixed the case where getting a DecisionTreeFactor from an empty or singular TableFactor would throw a segfault.
  3. Use faster sets and vectors.

@varunagrawal varunagrawal requested a review from dellaert January 2, 2025 20:35
@varunagrawal varunagrawal self-assigned this Jan 2, 2025
@varunagrawal varunagrawal mentioned this pull request Jan 2, 2025
Merged
dellaert
dellaert approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@dellaert dellaert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I guess this does not yet fix the "divide" bug?

@varunagrawal
Copy link
Collaborator Author

Cool! I guess this does not yet fix the "divide" bug?

The divide bug is in DecisionTreeFactor (at least from what I've seen). I'll check in TableFactor as well.

@varunagrawal varunagrawal merged commit 05d8030 into develop Jan 2, 2025
33 checks passed
@varunagrawal varunagrawal deleted the table-factor-fixes branch January 2, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dellaert dellaert dellaert approved these changes

Assignees

@varunagrawal varunagrawal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunagrawal @dellaert