Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a missing field in Matlab's CMakeLists.txt for UNSTABLE build #1677

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Add a missing field in Matlab's CMakeLists.txt for UNSTABLE build #1677

merged 1 commit into from
Nov 28, 2023

Conversation

etamarlu
Copy link
Contributor

add a missing field to "matlab_wrap" when GTSAM_UNSTABLE_INSTALL_MATLAB_TOOLBOX=ON

@etamarlu
Update CMakeLists.txt
bf6680b 
add a missing field to "matlab_wrap" when GTSAM_UNSTABLE_INSTALL_MATLAB_TOOLBOX=ON
@etamarlu etamarlu changed the title Update CMakeLists.txt Add missing a field in Matlab's CMakeLists.txt for UNSTABLE build Nov 27, 2023
@etamarlu etamarlu changed the title Add missing a field in Matlab's CMakeLists.txt for UNSTABLE build Add a missing field in Matlab's CMakeLists.txt for UNSTABLE build Nov 27, 2023
varunagrawal
varunagrawal approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@varunagrawal varunagrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ProfFan ProfFan merged commit 5d563b5 into borglab:develop Nov 28, 2023
26 checks passed
@etamarlu etamarlu deleted the CMake_UNSTABLE_Corrected branch November 28, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varunagrawal varunagrawal varunagrawal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etamarlu @varunagrawal @ProfFan