fix(nix): support skia-bindings v0.99.0#171
Merged
Merged
Conversation
Contributor
|
Thanks for the version bump! I'm also adding a CI job to test those in the future. |
m3nu
added a commit
that referenced
this pull request
Jul 12, 2026
Verifies all pinned flake inputs (narHash check for every input, including the three skia-binaries tarballs), evaluates flake outputs for all systems, and builds the three packages on x86_64-linux. Paths-filtered so it only runs when the flake, nix definitions, or Cargo manifests change. Closes the gap where lock-file PRs like #171 had no machine verification.
m3nu
added a commit
that referenced
this pull request
Jul 12, 2026
* ci: add nix flake verification and build job Verifies all pinned flake inputs (narHash check for every input, including the three skia-binaries tarballs), evaluates flake outputs for all systems, and builds the three packages on x86_64-linux. Paths-filtered so it only runs when the flake, nix definitions, or Cargo manifests change. Closes the gap where lock-file PRs like #171 had no machine verification. * ci(nix): fail fast when skia-binaries pins drift from Cargo.lock skia-bindings' build script does not validate the archive supplied via SKIA_BINARIES_URL, so a stale flake pin silently builds against outdated skia binaries instead of failing the build.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #170