tests: Add parameterized integration test infrastructure #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
cross-distro-split
branch
from
0f1ea67 to
9ac079b
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a well-designed infrastructure for parameterized integration tests, which is a great improvement for testing against multiple container images. The implementation is clean, with good use of linkme::distributed_slice to mirror the existing test registration pattern. The changes to the Justfile and the refactoring of existing tests to use the new system are also well-executed. I have a couple of minor suggestions to make the code even more idiomatic and efficient, but overall this is excellent work.
This introduces a matrix-based testing approach for integration tests that need to run against multiple container images. Instead of hardcoding specific images or manually creating variants for each distribution, tests can now register as parameterized tests and automatically run once per image in BCVK_ALL_IMAGES. This enables systematic cross-distribution testing without code duplication and makes it easy to add or change the test matrix by updating environment variables rather than modifying test code. Assisted-by: Claude Code (Sonnet 4.5) Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
cross-distro-split
branch
from
9ac079b to
938c2c4
Compare
jeckersb
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a matrix-based testing approach for integration tests that need to run against multiple container images. Instead of hardcoding specific images or manually creating variants for each distribution, tests can now register as parameterized tests and automatically run once per image in BCVK_ALL_IMAGES.
This enables systematic cross-distribution testing without code duplication and makes it easy to add or change the test matrix by updating environment variables rather than modifying test code.
Assisted-by: Claude Code (Sonnet 4.5)