feat: Add KubeVirt common-instancetypes support #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces support for KubeVirt common-instancetypes, which is a great feature for standardizing VM sizing. The implementation looks solid, adding the --itype flag to both bcvk ephemeral run and bcvk libvirt run and correctly overriding CPU/memory settings. The new instancetypes.rs module is well-structured.
My feedback focuses on improving the tests in instancetypes.rs to be more robust and maintainable by using data-driven approaches and strum::EnumIter. I've also suggested an improvement to an integration test to make it more thorough. The changes to the command-line options and documentation are clear and well-executed.
cgwalters
force-pushed
the
bcvk.kubevirt-sizes
branch
from
21cb048 to
c39e70b
Compare
Add support for KubeVirt common-instancetypes to provide standardized VM sizing. Basically it's annoying to have to specify cpus and memory separately always since they're often *related*, and that's the whole idea of the generic instance type. We only expose the U1 (Universal) series instancetype definitions from kubevirt/common-instancetypes because we're not a true cloud. Both `bcvk ephemeral run` and `bcvk libvirt run` now accept an `--itype` flag that overrides `--vcpus` and `--memory` settings, making it easier to create consistently-sized VMs across different environments. For libvirt VMs, the instance type is stored in domain metadata as `bootc:instance-type` for reference. Assisted-by: Claude Code (Sonnet 4.5) Signed-off-by: Colin Walters <[email protected]>
cgwalters
force-pushed
the
bcvk.kubevirt-sizes
branch
from
c39e70b to
970f008
Compare
jeckersb
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for KubeVirt common-instancetypes to provide standardized VM sizing. Basically it's annoying to have to specify cpus and memory separately always since they're often related, and that's the whole idea of the generic instance type.
We only expose the U1 (Universal) series instancetype definitions from kubevirt/common-instancetypes because we're not a true cloud.
Both
bcvk ephemeral runandbcvk libvirt runnow accept an--itypeflag that overrides--vcpusand--memorysettings, making it easier to create consistently-sized VMs across different environments.For libvirt VMs, the instance type is stored in domain metadata as
bootc:instance-typefor reference.Assisted-by: Claude Code (Sonnet 4.5)