Skip to content

Conversation

@cgwalters
Copy link
Collaborator

With a helper fn.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a helpful utility function, run_virsh_xml, to centralize and simplify the process of running virsh commands and parsing their XML output. This is a good refactoring that reduces code duplication and improves maintainability across several files. However, I've found one instance where the new implementation introduces a regression in error handling by silently swallowing errors that were previously propagated. My review includes a comment with a suggested fix for this issue.

With a helper fn.

Signed-off-by: Colin Walters <[email protected]>
@jeckersb jeckersb merged commit 7625a2b into bootc-dev:main Nov 3, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants