-
Notifications
You must be signed in to change notification settings - Fork 9
homebrew: Add Homebrew tap support #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This adds a Homebrew formula for bcvk, addressing issue bootc-dev#100. The formula supports both stable releases and HEAD installations. Users can install with: brew install bootc-dev/bcvk/bcvk Closes: bootc-dev#100 Assisted-by: Claude Code (Sonnet 4.5) Signed-off-by: Colin Walters <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces Homebrew support for bcvk, which is a valuable addition for easier installation on Linux. The Homebrew formula is well-crafted and follows current best practices, and the accompanying documentation changes are clear and helpful. My review includes one suggestion to add a livecheck block to the formula, which will improve its long-term maintainability by enabling automatic version updates.
| url "https://github.com/bootc-dev/bcvk/archive/refs/tags/v0.5.3.tar.gz" | ||
| sha256 "67c632b26513f77edcf63b3da8b22941a4ef467c984bfce301544533a1f12979" | ||
| license any_of: ["MIT", "Apache-2.0"] | ||
| head "https://github.com/bootc-dev/bcvk.git", branch: "main" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a well-written Homebrew formula. To improve its long-term maintainability, I suggest adding a livecheck block. This allows Homebrew's infrastructure to automatically detect new releases of bcvk and open pull requests to update the formula, ensuring users get timely updates.
head "https://github.com/bootc-dev/bcvk.git", branch: "main"
livecheck do
url :stable
strategy :github_latest
end|
I only very superficially tested this locally (didn't test the GHA flow before this push but it should cover the basics). |
|
I think this needs to be on a separate repository with the |
|
I made a repository for this, could it be cloned or moved into the |
|
OK so we can have multiple taps in a single git repo? If so let's just call it |
You can have multiple formulas (~packages) in the same git repo (~tap) |
|
And thanks for working on this! As far as homebrew on Linux...I was initially primed to like it, but after looking at some of the implementation choices (ruby code not a declarative format, Though I think we should support https://crates.io/crates/cargo-binstall too. |
This adds a Homebrew formula for bcvk, addressing issue #100.
The formula supports both stable releases and HEAD installations. Users can install with:
brew install bootc-dev/bcvk/bcvk
Closes: #100
Assisted-by: Claude Code (Sonnet 4.5)