Skip to content

Redis Window Metrics: smaller event keys - #900

Closed
bolshakov wants to merge 1 commit into
feature/windowed-metrics-memory-optimizationfrom
feature/incremental-member-ids
Closed

bolshakov wants to merge 1 commit into
feature/windowed-metrics-memory-optimizationfrom
feature/incremental-member-ids

Conversation

@bolshakov

@bolshakov bolshakov commented Aug 27, 2026 •

Copy link
Copy Markdown
Owner

Further reduces amount of data stored as ZSET members for window metrics. Benchmark results in. At 15,000 members (50 req/s, 300s window):

approach KB bytes/member
hex-24 (SecureRandom) 1,730 KB 118
int-seq (HINCRBY) 1,494 KB 102
savings ~236 KB/ZSET ~16

Performance benchmark results: difference falls withing noise

@github-actions

github-actions Bot commented Aug 27, 2026 •

Copy link
Copy Markdown

Review price tag

🟢 37 effective lines — about 5–11 min (down from 43–107 min) of focused review (based on 200–500 lines/hour). This is within the range where reviewers find the most issues per line, and small changes usually receive feedback the fastest.

Why these numbers?

These minutes are what careful defect-finding costs at 200–500 lines/hour — the rate review studies report, not how long a skim takes. "Effective lines" already exclude generated files and lockfiles. Treat the rates and the 200/400 thresholds as guardrails, not laws.

@github-actions github-actions Bot added the proquo: medium ProQuo review price tier: medium label Aug 27, 2026
@bolshakov
bolshakov changed the base branch from develop to feature/windowed-metrics-memory-optimization August 27, 2026 22:35
@github-actions github-actions Bot added proquo: small ProQuo review price tier: small and removed proquo: medium ProQuo review price tier: medium labels Aug 27, 2026
@bolshakov
bolshakov marked this pull request as ready for review August 28, 2026 07:21
@bolshakov
bolshakov marked this pull request as draft August 28, 2026 11:01
@bolshakov

Copy link
Copy Markdown
Owner Author

Replaced by #904

@bolshakov bolshakov closed this Aug 31, 2026
@bolshakov
bolshakov deleted the feature/incremental-member-ids branch August 31, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

proquo: small ProQuo review price tier: small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant