Fix off-by-one error in check_all's capacity check #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #11:
I'd missed that the "weight" variable is additional weight that gets
added to the first cell, so check_all (when given one more element
than fit in the burst capacity) would return a "denied" result instead
of an "insufficient capacity" result - effectively preventing futures
from ever completing.
Now, we treat additional weight as what it is:
going on
error potential
the off-by-one, to prevent regressions.
Thanks to @jean-airoldie for discovering the bug & reporting it!