Enhance resource error handling

[bohning]

No description provided.

[RumovZ]

If we decide to implement this, it should probably be opt-in or users might negatively view it as some kind of telemetry.

[RumovZ]

cast is for fixing type checking issues, but this is not one. The function definition clearly states that logger is a Log and not (necessarily) a SongLogger.

[bohning]

Like this?

if isinstance(logger, SongLogger):
    notify_discord(logger.song_id, url, logger)

Or like this?

assert isinstance(logger, SongLogger):
notify_discord(logger.song_id, url, logger)

[RumovZ]

I think the underlying issue is that notify_discord should not be called in download_resource. download_resource is a lower-level functioning working with a bare URL. notify_discord should be called from a higher-level function that has the necessary context, the song id.

[randompersona1]

If we decide to implement this, it should probably be opt-in or users might negatively view it as some kind of telemetry.

I'd like to add it should probably be disabled when the syncer is run from source as opposed to the binary, since that could unintentionally spam the webhook when some functions are changed.

[bohning]

If we decide to implement this, it should probably be opt-in or users might negatively view it as some kind of telemetry.

I added a setting to disable anonymous Discord notifications.