Skip to content

fix: use timedelta in pr_reporting test fixture to avoid month overflow #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maui314159 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use timedelta in pr_reporting test fixture to avoid month overflow #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/reports/test_pr_reporting.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
from __future__ import annotations

import csv
from datetime import datetime, timezone
from datetime import datetime, timedelta, timezone
from io import StringIO
from pathlib import Path
from typing import Any
Expand Down Expand Up @@ -105,8 +105,8 @@ def review_prs(recent_date: datetime) -> list[dict[str, Any]]:
"title": "Add tests",
"author": "bob",
"canonical_id": "bob@example.com",
"created_at": recent_date.replace(day=recent_date.day + 1),
"merged_at": recent_date.replace(day=recent_date.day + 1, hour=14),
"created_at": recent_date + timedelta(days=1),
"merged_at": (recent_date + timedelta(days=1)).replace(hour=14),
"additions": 150,
"deletions": 0,
"changed_files": 6,
Expand All @@ -126,8 +126,8 @@ def review_prs(recent_date: datetime) -> list[dict[str, Any]]:
"title": "Update docs",
"author": "alice",
"canonical_id": "alice@example.com",
"created_at": recent_date.replace(day=recent_date.day + 2),
"merged_at": recent_date.replace(day=recent_date.day + 2, hour=11),
"created_at": recent_date + timedelta(days=2),
"merged_at": (recent_date + timedelta(days=2)).replace(hour=11),
"additions": 30,
"deletions": 5,
"changed_files": 2,
Expand Down