Syntax highlighting improvement for INI #622
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #622 +/- ##
=========================================
Coverage 80.53% 80.53%
- Complexity 7865 7879 +14
=========================================
Files 180 180
Lines 30438 30481 +43
Branches 3925 3928 +3
=========================================
+ Hits 24513 24548 +35
- Misses 4256 4265 +9
+ Partials 1669 1668 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bobbylight
reviewed
Jun 15, 2025
RSyntaxTextArea/src/main/java/org/fife/ui/rsyntaxtextarea/modes/IniTokenMaker.flex
Outdated
Show resolved
Hide resolved
bobbylight
reviewed
Jun 15, 2025
| reset(text, 0, text.count, 0); | ||
| yylex(); | ||
| } catch (IOException e) { | ||
| throw new RuntimeException(e); |
Owner
There was a problem hiding this comment.
This will crash some apps if there is a bug in the highlighting. While RSTA's current behavior of silently returning not text isn't great, I'd rather keep the current behavior consistent across all TokenMakers.
Contributor
Author
There was a problem hiding this comment.
This and the previous issue have been fixed: the semicolon is restored as comment marker and no exception is thrown during unexpected lexical errors.
…nymore an exception during list-making
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referring to #607, the following changes has been made:
[some text]) is no longer recognized as an INI section when placed in a property value contextTokenTypes.LITERAL_STRING_DOUBLE_QUOTE)