Skip to content

fix destructuring property reference target order #4336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix destructuring property reference target order #4336

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
479320b
fix keyed-destructuring-property-reference-target-evaluation-order-wi…
dotcarmen Jul 14, 2025
339103e
fix handling of default inits
dotcarmen Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 24 additions & 8 deletions core/engine/src/bytecompiler/declaration/declaration_pattern.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,43 +39,59 @@ impl ByteCompiler<'_> {
let dst = self.register_allocator.alloc();

match name {
PropertyName::Literal(ident) => {
PropertyName::Literal(field_ident) => {
self.emit_get_property_by_name(
&dst,
object,
object,
ident.sym(),
field_ident.sym(),
);
let key = self.register_allocator.alloc();
self.emit_push_literal(
Literal::String(
self.interner()
.resolve_expect(ident.sym())
.resolve_expect(field_ident.sym())
.into_common(false),
),
&key,
);
excluded_keys_registers.push(key);
self.emit_binding(
def,
ident.to_js_string(self.interner()),
&dst,
);
}
PropertyName::Computed(node) => {
let key = self.register_allocator.alloc();
self.compile_expr(node, &key);
let property_key = self.register_allocator.alloc();
self.bytecode.emit_to_property_key(
key.variable(),
property_key.variable(),
);
self.register_allocator.dealloc(key);
self.emit_binding(
def,
ident.to_js_string(self.interner()),
&dst,
);
if rest_exits {
self.bytecode.emit_get_property_by_value_push(
dst.variable(),
key.variable(),
property_key.variable(),
object.variable(),
object.variable(),
);
excluded_keys_registers.push(key);
excluded_keys_registers.push(property_key);
} else {
self.bytecode.emit_get_property_by_value(
dst.variable(),
key.variable(),
property_key.variable(),
object.variable(),
object.variable(),
);
self.register_allocator.dealloc(key);
self.register_allocator.dealloc(property_key);
}
}
}
Expand All @@ -84,9 +100,9 @@ impl ByteCompiler<'_> {
let skip = self.emit_jump_if_not_undefined(&dst);
self.compile_expr(init, &dst);
self.patch_jump(skip);
self.emit_binding(def, ident.to_js_string(self.interner()), &dst);
}

self.emit_binding(def, ident.to_js_string(self.interner()), &dst);
self.register_allocator.dealloc(dst);
}
// BindingRestProperty : ... BindingIdentifier
Expand Down
Loading