[RELEASE] version 1.1.2 #14
Conversation
…mo & add logic diagram
bnbong
added
documentation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull Request Overview
This release version 1.1.2 adds enhanced project creation flexibility by allowing users to choose between creating new project folders or deploying directly to the current directory, improves command-line interface for route management, and includes several bug fixes and dependency updates.
- Enhanced
fastkit initandfastkit startdemocommands with optional project folder creation - Updated
fastkit addroutecommand to support current directory operations and improved parameter ordering - Added setuptools dependency to fastapi-empty template and updated test coverage
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/fastapi_fastkit/init.py | Version bump to 1.1.2 |
| src/fastapi_fastkit/cli.py | Enhanced CLI commands with folder creation options and improved addroute functionality |
| src/fastapi_fastkit/backend/main.py | Added new functions for project folder creation and template deployment |
| src/fastapi_fastkit/fastapi_project_template/fastapi-empty/requirements.txt-tpl | Added setuptools dependency |
| tests/ | Updated test cases to handle new confirmation prompts and command parameter changes |
| CHANGELOG.md | Added release notes for version 1.1.2 |
| CONTRIBUTING.md | Added architecture diagram reference |
| .pre-commit-config.yaml | Removed check-added-large-files hook |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @click.argument("route_name") | ||
| @click.argument("project_dir", default=".") |
There was a problem hiding this comment.
The project_dir argument should use click.argument with required=False instead of default='.'. Using default with click.argument is not the standard pattern; consider using @click.option instead or handle the default value logic in the function body.
| # when | ||
| result = self.runner.invoke( | ||
| fastkit_cli, ["addroute", project_name, route_name], input="Y" | ||
| fastkit_cli, ["addroute", route_name, project_name], input="Y" |
There was a problem hiding this comment.
The test is still using the old parameter order (route_name, project_name) but the CLI function now expects (route_name, project_dir). This will cause the test to fail because it's passing arguments in the wrong order according to the updated CLI signature.
| # when | ||
| result = self.runner.invoke( | ||
| fastkit_cli, ["addroute", project_name, route_name], input="N" | ||
| fastkit_cli, ["addroute", route_name, project_name], input="N" |
There was a problem hiding this comment.
Same parameter order issue as the previous test - should be (route_name, project_dir) to match the updated CLI signature.
| fastkit_cli, ["addroute", route_name, project_name], input="N" | |
| fastkit_cli, ["addroute", route_name, str(project_path)], input="N" |
| # addroute command requires route_name and project_dir as arguments | ||
| result = self.runner.invoke( | ||
| fastkit_cli, ["addroute", project_name, "test_route"], input="Y" | ||
| fastkit_cli, ["addroute", "test_route", project_name], input="Y" |
There was a problem hiding this comment.
These test calls are using project_name as the second argument, but according to the updated CLI signature, the second argument should be project_dir. The tests should be consistent with the new parameter order (route_name, project_dir).
| # when | ||
| result = self.runner.invoke( | ||
| fastkit_cli, ["addroute", project_name, "test_route"], input="Y" | ||
| fastkit_cli, ["addroute", "test_route", project_name], input="Y" |
There was a problem hiding this comment.
These test calls are using project_name as the second argument, but according to the updated CLI signature, the second argument should be project_dir. The tests should be consistent with the new parameter order (route_name, project_dir).
| # addroute command requires route_name and project_dir as arguments | ||
| result = self.runner.invoke( | ||
| fastkit_cli, ["addroute", project_name, "test_route"], input="N" | ||
| fastkit_cli, ["addroute", "test_route", project_name], input="N" |
There was a problem hiding this comment.
These test calls are using project_name as the second argument, but according to the updated CLI signature, the second argument should be project_dir. The tests should be consistent with the new parameter order (route_name, project_dir).
| fastkit_cli, ["addroute", "test_route", project_name], input="N" | |
| fastkit_cli, ["addroute", "test_route", str(project_path)], input="N" |
Requesting Merging
Description
fastkit init,fastkit startdemocommand to define to make a new project folder at current working directorysetuptoolspackage atfastapi-emptytemplate's dependency list.fastkit addroutecommand to recognize current working project (with cmd option.).Type of Change
Test Environment
local, MacOS Apple Silicon
Major Changes
Same as above.
Screenshots (optional)
Etc
close #13