Repository navigation
Conversation
lrhn
approved these changes
Aug 5, 2026
lrhn
left a comment
lrhn
left a comment
There was a problem hiding this comment.
This contains the changes of the other PR too?
See comments on that.
| final childPrefix = prefix + (isLast ? ' ' : '│ '); | ||
| final node = nodes[i]; | ||
| if (node is Map) { | ||
| final label = node['label']?.toString() ?? ''; |
There was a problem hiding this comment.
Looks like the same logic as in _createTree, if that was parameterized by a prefix and called with '$prefix$connector'.
Can it be reused?
…ndencies - Remove unused pubspec_manager dependency from root pubspec.yaml - Replace package:stack Stack<Declaration> with standard Dart List<Declaration> - Replace package:tuple Tuple2 with Dart 3 Records - Replace package:plist_parser with regular expression matching for MinimumOSVersion in plist files - Bump version to 0.23.3 for semver check
mosuem
force-pushed
the
remove-remaining-3p-deps
branch
from
August 6, 2026 14:44
d94e6f6 to
64b6e78
Compare
…sh dependencies - Remove package:colorize in favor of standard ANSI escape sequences in ColorUtils - Remove package:console in favor of standard ANSI terminal cursor control and a custom ASCII tree formatter - Remove package:lumberdash and package:colorize_lumberdash in favor of standard stderr.writeln warnings and errors
mosuem
force-pushed
the
remove-remaining-3p-deps
branch
from
August 6, 2026 15:03
64b6e78 to
6e94a06
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package:colorizein favor of standard ANSI escape sequences inColorUtilspackage:consolein favor of standard ANSI terminal cursor control and a custom ASCII tree formatter (_createTree)package:lumberdashandpackage:colorize_lumberdashin favor of standardstderr.writelnwarnings and errorsfreezed_annotationin runtime dependencies