Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scaling issue on linux with high DPI monitor #21

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

wilsonk
Copy link
Contributor

@wilsonk wilsonk commented Oct 11, 2024

You may want to change names of variables or functions here. Fixes the issue, for all demos except multiscene, on Linux and works on MacOS M1 (not tested on Windows). Fixes issue #20

@redthing1
Copy link
Member

great, thanks for looking into it. I will have to test a bit and i'll merge it when im done. feel free to ping if i forget about it

@redthing1 redthing1 merged commit 0b36bfc into bmchtech:master Oct 12, 2024
@redthing1
Copy link
Member

Looks like I merged this prematurely, I found some breakage in celtest.

@redthing1
Copy link
Member

redthing1 commented Oct 12, 2024

moved to fix-dpi branch

@redthing1
Copy link
Member

Sorry, looking at it more, I think the PR was totally broken to begin with. I rushed into merging it

@wilsonk
Copy link
Contributor Author

wilsonk commented Oct 12, 2024

Ah, actually I see a difference on my M1 for celtest now...perhaps I didn't recompile that one to test. Seems like the view is too close.

Pong is the same, but can be fixed with this patch and changing the actual ball/paddles/scores placements manually in the example code.

So, not totally sure how you wanted to fix this...but it seems like anything that is setting a view/scene offset by resolution will have some issues with this fix, as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants