Exclude alignment for MaskBuffer for i686-win7-windows-msvc #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows 7 does not respect 16 byte alignment for thread locals on i686 builds. Rust 1.79 changed i686 windows builds to use native thread local support. As a result, using `matrixmultiply` on i686 win7 builds leads to a UB check panic nounwind when run on Windows 7. See <rust-lang/rust#138903> for more info. This change adds `i686-win7-windows-msvc` as an excluded target for the alignment attribute on `MaskBuffer`.
|
Thanks, at this point we should have more or less abandoned any hope for that custom alignment. I will include your change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows 7 does not respect 16 byte alignment for thread locals on i686
builds. Rust 1.79 changed i686 windows builds to use native thread local
support. As a result, using
matrixmultiplyon i686 win7 builds leadsto a UB check panic nounwind when run on Windows 7. See
rust-lang/rust#138903 for more info.
This change adds
i686-win7-windows-msvcas an excluded target for thealignment attribute on
MaskBuffer.Not sure how you feel about adding this exclusion in
matrixmultiplyas itsvery much for a tier 3 target that you can't test in CI that its useful. But
figured I'd raise it, as it would affect users using that target on any recent
toolchain version. And fwiw, i did test that this does in fact have the desire
for compilations targeting i686-win7