Exclude posts from author feed when they don't fit into a self-thread #2347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When viewing
getAuthorFeedwith theposts_and_author_threadsfilter, previously the appview would serve any reply that the author posted in their own thread in reply to one of their own posts. This could end-up including posts that were not part of a self-thread, even if they appeared to be "locally" by inspecting their root and parent.With this change, when we encounter a reply we ensure that the full reply chain up to the root is included in the author feed. Otherwise we filter it out—this should ensure that only proper self-threads are served when using the
posts_and_author_threadsfilter.