Handle apostrophes and other punctuation when muting words #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estrattonbailey
force-pushed
the
eric/muted-apos
branch
from
11f5dd0 to
66d2db2
Compare
estrattonbailey
commented
Mar 19, 2024
| @@ -417,7 +495,7 @@ describe(`hasMutedWord`, () => { | |||
| outlineTags: [], | |||
| }) | |||
|
|
|||
| expect(match).toBe(false) | |||
| expect(match).toBe(true) | |||
There was a problem hiding this comment.
This update allows superbad to match super-bad, basically collapses the punctuation. Previously super bad would match super-bad but not the collapsed version.
This was done so that blueskys match Bluesky's. I'm trying to think of cases where this would be TOO eager, but haven't come up with anything yet.
estrattonbailey
commented
Mar 19, 2024
| @@ -474,7 +552,7 @@ describe(`hasMutedWord`, () => { | |||
| outlineTags: [], | |||
| }) | |||
|
|
|||
| expect(match).toBe(false) | |||
| expect(match).toBe(true) | |||
There was a problem hiding this comment.
Same thing here, collapses _ so idkwhatthiswouldbe matches idk_what_this_would_be
estrattonbailey
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.