Fix: elevate !no-unauthenticated label to affect the entire account w…

…hen on the profile (#1966) * Fix: elevate !no-unauthenticated label to affect the entire account when on the profile * lint * Add changeset --------- Co-authored-by: dholms <[email protected]>
bluesky-social · Dec 14, 2023 · 8f3f43c · 8f3f43c
1 parent 8d4a87c
commit 8f3f43c
Show file tree

Hide file tree

Showing 6 changed files with 24 additions and 4 deletions.
diff --git a/.changeset/spotty-ducks-lie.md b/.changeset/spotty-ducks-lie.md
@@ -0,0 +1,5 @@
+---
+'@atproto/api': patch
+---
+
+Fix to the application of the no-unauthenticated label
diff --git a/packages/api/definitions/post-moderation-behaviors.json b/packages/api/definitions/post-moderation-behaviors.json
@@ -271,6 +271,12 @@
       "author": "alice",
       "labels": { "profile": ["!no-unauthenticated"] },
       "behaviors": {
+        "content": {
+          "cause": "label:!no-unauthenticated",
+          "filter": true,
+          "blur": true,
+          "noOverride": true
+        },
         "avatar": {
           "cause": "label:!no-unauthenticated",
           "blur": true,

diff --git a/packages/api/definitions/profile-moderation-behaviors.json b/packages/api/definitions/profile-moderation-behaviors.json
@@ -185,6 +185,12 @@
       "author": "alice",
       "labels": { "profile": ["!no-unauthenticated"] },
       "behaviors": {
+        "account": {
+          "cause": "label:!no-unauthenticated",
+          "filter": true,
+          "blur": true,
+          "noOverride": true
+        },
         "profile": {
           "cause": "label:!no-unauthenticated",
           "blur": true,

diff --git a/packages/api/docs/moderation-behaviors/posts.md b/packages/api/docs/moderation-behaviors/posts.md
@@ -286,10 +286,10 @@ Key:
 <tr>
 <td><strong>Imperative label ('!no-unauthenticated') on author profile when logged out</strong></td>
 <td>
-
+❌
 </td>
 <td>
-
+🚫
 </td>
 <td>
 🚫

diff --git a/packages/api/docs/moderation-behaviors/profiles.md b/packages/api/docs/moderation-behaviors/profiles.md
@@ -152,9 +152,10 @@ Key:
 <tr>
 <td><strong>Imperative label ('!no-unauthenticated') on profile when logged out</strong></td>
 <td>
-
+❌
 </td>
 <td>
+🚫
 
 </td>
 <td>

diff --git a/packages/api/src/moderation/subjects/account.ts b/packages/api/src/moderation/subjects/account.ts
@@ -41,6 +41,8 @@ export function filterAccountLabels(labels?: Label[]): Label[] {
     return []
   }
   return labels.filter(
-    (label) => !label.uri.endsWith('/app.bsky.actor.profile/self'),
+    (label) =>
+      !label.uri.endsWith('/app.bsky.actor.profile/self') ||
+      label.val === '!no-unauthenticated',
   )
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -286,10 +286,10 @@ Key: @@
     <tr>
     <td><strong>Imperative label ('!no-unauthenticated') on author profile when logged out</strong></td>
     <td>
+    ❌
     </td>
     <td>
+    🚫
     </td>
     <td>
     🚫
@@ Expand Down @@