Skip to content

Commit

Permalink
Fix avatar path resolution in dev-env (#3266)
Browse files Browse the repository at this point in the history
* Fix avatar path resolution in dev-env

* changeset

* extract dev-env assets to dedicated folder

* add comment

* fix fmt
  • Loading branch information
rafaelbsky authored Dec 19, 2024
1 parent c559e7e commit 638f5a8
Show file tree
Hide file tree
Showing 36 changed files with 241 additions and 243 deletions.
5 changes: 5 additions & 0 deletions .changeset/moody-hotels-shop.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@atproto/dev-env": patch
---

Fix avatar path resolution
32 changes: 16 additions & 16 deletions packages/bsky/tests/__snapshots__/feed-generation.test.ts.snap
Original file line number Diff line number Diff line change
Expand Up @@ -665,12 +665,12 @@ Array [
"$type": "app.bsky.embed.images#view",
"images": Array [
Object {
"alt": "../dev-env/src/seed/img/key-landscape-small.jpg",
"alt": "../dev-env/assets/key-landscape-small.jpg",
"fullsize": "https://bsky.public.url/img/feed_fullsize/plain/user(5)/cids(5)@jpeg",
"thumb": "https://bsky.public.url/img/feed_thumbnail/plain/user(5)/cids(5)@jpeg",
},
Object {
"alt": "../dev-env/src/seed/img/key-alt.jpg",
"alt": "../dev-env/assets/key-alt.jpg",
"fullsize": "https://bsky.public.url/img/feed_fullsize/plain/user(5)/cids(6)@jpeg",
"thumb": "https://bsky.public.url/img/feed_thumbnail/plain/user(5)/cids(6)@jpeg",
},
Expand Down Expand Up @@ -727,7 +727,7 @@ Array [
"$type": "app.bsky.embed.images",
"images": Array [
Object {
"alt": "../dev-env/src/seed/img/key-landscape-small.jpg",
"alt": "../dev-env/assets/key-landscape-small.jpg",
"image": Object {
"$type": "blob",
"mimeType": "image/jpeg",
Expand All @@ -738,7 +738,7 @@ Array [
},
},
Object {
"alt": "../dev-env/src/seed/img/key-alt.jpg",
"alt": "../dev-env/assets/key-alt.jpg",
"image": Object {
"$type": "blob",
"mimeType": "image/jpeg",
Expand Down Expand Up @@ -950,12 +950,12 @@ Array [
"$type": "app.bsky.embed.images#view",
"images": Array [
Object {
"alt": "../dev-env/src/seed/img/key-landscape-small.jpg",
"alt": "../dev-env/assets/key-landscape-small.jpg",
"fullsize": "https://bsky.public.url/img/feed_fullsize/plain/user(5)/cids(5)@jpeg",
"thumb": "https://bsky.public.url/img/feed_thumbnail/plain/user(5)/cids(5)@jpeg",
},
Object {
"alt": "../dev-env/src/seed/img/key-alt.jpg",
"alt": "../dev-env/assets/key-alt.jpg",
"fullsize": "https://bsky.public.url/img/feed_fullsize/plain/user(5)/cids(6)@jpeg",
"thumb": "https://bsky.public.url/img/feed_thumbnail/plain/user(5)/cids(6)@jpeg",
},
Expand Down Expand Up @@ -1015,7 +1015,7 @@ Array [
"$type": "app.bsky.embed.images",
"images": Array [
Object {
"alt": "../dev-env/src/seed/img/key-landscape-small.jpg",
"alt": "../dev-env/assets/key-landscape-small.jpg",
"image": Object {
"$type": "blob",
"mimeType": "image/jpeg",
Expand All @@ -1026,7 +1026,7 @@ Array [
},
},
Object {
"alt": "../dev-env/src/seed/img/key-alt.jpg",
"alt": "../dev-env/assets/key-alt.jpg",
"image": Object {
"$type": "blob",
"mimeType": "image/jpeg",
Expand Down Expand Up @@ -1180,12 +1180,12 @@ Array [
"$type": "app.bsky.embed.images#view",
"images": Array [
Object {
"alt": "../dev-env/src/seed/img/key-landscape-small.jpg",
"alt": "../dev-env/assets/key-landscape-small.jpg",
"fullsize": "https://bsky.public.url/img/feed_fullsize/plain/user(3)/cids(4)@jpeg",
"thumb": "https://bsky.public.url/img/feed_thumbnail/plain/user(3)/cids(4)@jpeg",
},
Object {
"alt": "../dev-env/src/seed/img/key-alt.jpg",
"alt": "../dev-env/assets/key-alt.jpg",
"fullsize": "https://bsky.public.url/img/feed_fullsize/plain/user(3)/cids(5)@jpeg",
"thumb": "https://bsky.public.url/img/feed_thumbnail/plain/user(3)/cids(5)@jpeg",
},
Expand Down Expand Up @@ -1236,7 +1236,7 @@ Array [
"$type": "app.bsky.embed.images",
"images": Array [
Object {
"alt": "../dev-env/src/seed/img/key-landscape-small.jpg",
"alt": "../dev-env/assets/key-landscape-small.jpg",
"image": Object {
"$type": "blob",
"mimeType": "image/jpeg",
Expand All @@ -1247,7 +1247,7 @@ Array [
},
},
Object {
"alt": "../dev-env/src/seed/img/key-alt.jpg",
"alt": "../dev-env/assets/key-alt.jpg",
"image": Object {
"$type": "blob",
"mimeType": "image/jpeg",
Expand Down Expand Up @@ -1477,12 +1477,12 @@ Array [
"$type": "app.bsky.embed.images#view",
"images": Array [
Object {
"alt": "../dev-env/src/seed/img/key-landscape-small.jpg",
"alt": "../dev-env/assets/key-landscape-small.jpg",
"fullsize": "https://bsky.public.url/img/feed_fullsize/plain/user(3)/cids(4)@jpeg",
"thumb": "https://bsky.public.url/img/feed_thumbnail/plain/user(3)/cids(4)@jpeg",
},
Object {
"alt": "../dev-env/src/seed/img/key-alt.jpg",
"alt": "../dev-env/assets/key-alt.jpg",
"fullsize": "https://bsky.public.url/img/feed_fullsize/plain/user(3)/cids(5)@jpeg",
"thumb": "https://bsky.public.url/img/feed_thumbnail/plain/user(3)/cids(5)@jpeg",
},
Expand Down Expand Up @@ -1539,7 +1539,7 @@ Array [
"$type": "app.bsky.embed.images",
"images": Array [
Object {
"alt": "../dev-env/src/seed/img/key-landscape-small.jpg",
"alt": "../dev-env/assets/key-landscape-small.jpg",
"image": Object {
"$type": "blob",
"mimeType": "image/jpeg",
Expand All @@ -1550,7 +1550,7 @@ Array [
},
},
Object {
"alt": "../dev-env/src/seed/img/key-alt.jpg",
"alt": "../dev-env/assets/key-alt.jpg",
"image": Object {
"$type": "blob",
"mimeType": "image/jpeg",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ Array [
"$type": "app.bsky.embed.images#view",
"images": Array [
Object {
"alt": "../dev-env/src/seed/img/key-landscape-small.jpg",
"alt": "../dev-env/assets/key-landscape-small.jpg",
"fullsize": "https://bsky.public.url/img/feed_fullsize/plain/user(2)/cids(5)@jpeg",
"thumb": "https://bsky.public.url/img/feed_thumbnail/plain/user(2)/cids(5)@jpeg",
},
Expand Down Expand Up @@ -176,7 +176,7 @@ Array [
"$type": "app.bsky.embed.images",
"images": Array [
Object {
"alt": "../dev-env/src/seed/img/key-landscape-small.jpg",
"alt": "../dev-env/assets/key-landscape-small.jpg",
"image": Object {
"$type": "blob",
"mimeType": "image/jpeg",
Expand Down Expand Up @@ -303,7 +303,7 @@ Array [
"$type": "app.bsky.embed.images",
"images": Array [
Object {
"alt": "../dev-env/src/seed/img/key-landscape-small.jpg",
"alt": "../dev-env/assets/key-landscape-small.jpg",
"image": Object {
"$type": "blob",
"mimeType": "image/jpeg",
Expand All @@ -314,7 +314,7 @@ Array [
},
},
Object {
"alt": "../dev-env/src/seed/img/key-alt.jpg",
"alt": "../dev-env/assets/key-alt.jpg",
"image": Object {
"$type": "blob",
"mimeType": "image/jpeg",
Expand Down
2 changes: 1 addition & 1 deletion packages/bsky/tests/image/sharp.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ describe('sharp image processor', () => {
})

async function processFixture(fixture: string, options: Options) {
const image = createReadStream(`../dev-env/src/seed/img/${fixture}`)
const image = createReadStream(`../dev-env/assets/${fixture}`)
const resized = await resize(image, options)
return await getInfo(resized)
}
Expand Down
Loading

0 comments on commit 638f5a8

Please sign in to comment.