-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add NTN (Non-Terrestrial Network) support #88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
devin-ai-integration
wants to merge
15
commits into
main
from
devin/1738174373-ntn-and-template-improvements
Closed
Changes from 3 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
392f224
- Add comprehensive test cases
devin-ai-integration[bot] e34770b
revert: remove changes to auto-generated docs/api.md
devin-ai-integration[bot] 2af6645
remove "allow" hallucination
rdlauer 0f2c5c5
refactor: move NTN functionality to card.transport
devin-ai-integration[bot] ccc4f0c
fix: remove NTN tests from card.wireless and add card fixture
devin-ai-integration[bot] b18a68c
fix: expose card.transport method in __init__.py
devin-ai-integration[bot] b80d671
fix: add abstract methods to Notecard base class and fix transport tests
devin-ai-integration[bot] 4aba6e0
fix: properly serialize boolean values and handle None responses in t…
devin-ai-integration[bot] d63b630
fix: move abc import to top and fix class spacing
devin-ai-integration[bot] 0f8d950
fix: implement abstract methods in test fixtures
devin-ai-integration[bot] b9f29ea
fix: remove whitespace in blank lines
devin-ai-integration[bot] 11b6bab
fix: properly serialize boolean values in card.transport and remove d…
devin-ai-integration[bot] 7a3d781
fix: update test_card_transport.py to use consistent module imports a…
devin-ai-integration[bot] 8e8a59c
fix: update conftest.py to use mock Notecard implementation consistently
devin-ai-integration[bot] f14629c
fix: clean up conftest.py by removing duplicate imports and whitespace
devin-ai-integration[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the wrong API to add the NTN methods to, it should be card.transport. Take a look at https://dev.blues.io/api-reference/notecard-api/card-requests/latest/#card-transport for how to implement this.