[WIP] pingmessage: Add function_map variable #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickelectric
changed the title
jaxxzer
approved these changes
Jul 30, 2018
|
That's something that I thought. But having two differents implementation of the same thing will increase the debug/development time. Also, the good point to use the same implementation for Qt and pure-cpp is that we catch a bug for both. |
This new variable will help us to create a better log from all function return the function name and the value on it. Right now this variable can't return pointer types. Signed-off-by: Patrick José Pereira <[email protected]>
Signed-off-by: Patrick José Pereira <[email protected]>
patrickelectric
changed the title
|
A subclass with the extra functions is still the same implementation. (I guess QPingMessage is not a good recommendation as it would imply QObject inheritance). We can leave it. |
|
We'll need to subclass all pure c++ classes . |
patrickelectric
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new variable will help us to create a better log from all function
return the function name and the value on it.
Right now this variable can't return pointer types.
Signed-off-by: Patrick José Pereira [email protected]