Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

widgets: Enable config menu for the DIY widget #1598

Merged

Conversation

rafaellehmkuhl
Copy link
Member

image

Fix #1597

@patrickelectric patrickelectric merged commit e56c2e9 into bluerobotics:master Jan 20, 2025
11 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the fix-diy-widget-cog branch January 21, 2025 00:12
@ES-Alexander
Copy link
Contributor

Thanks for the fix :-)

This seems like it should be a property of the widget definitions, not maintained as an external list.
Maybe that should be part of the changes when doing #1540 :-)

@rafaellehmkuhl
Copy link
Member Author

rafaellehmkuhl commented Jan 21, 2025

Thanks for the fix :-)

This seems like it should be a property of the widget definitions, not maintained as an external list.

Maybe that should be part of the changes when doing #1540 :-)

This was actually on purpose so we don't need to migrate everyone's widget to add this property.

But I agree we should internalize it at some point. I just prefer to avoid migrations when possible.

Also, this external list is typed in a way it will raise type check errors if a widget is not included. We didn't see that for the DIY widget because the CI was broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DIY widget displays as having no configuration option
3 participants