Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MAVLink inspection tool #1483

Merged

Conversation

rafaellehmkuhl
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl commented Dec 4, 2024

Opening as draft as there are things to polish yet.

This tool can help on different debugging processes, like finding out what exactly Cockpit is sending as MANUAL_CONTROL messages, live.

Kapture.2024-12-03.at.07.50.32.mp4

Fix #816.

@rafaellehmkuhl rafaellehmkuhl force-pushed the add-mavlink-inspector branch 2 times, most recently from 5d76384 to 0994070 Compare December 18, 2024 16:40
@rafaellehmkuhl rafaellehmkuhl force-pushed the add-mavlink-inspector branch 3 times, most recently from 44de82b to 431cf51 Compare January 8, 2025 14:50
@rafaellehmkuhl rafaellehmkuhl marked this pull request as ready for review January 8, 2025 14:52
Copy link
Contributor

@ArturoManzoli ArturoManzoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Very handy tool to have on Cockpit!

Some things to adjust on the UI:

1- If we're not configuring MavLink into it, but monitoring, this could be called 'Mavlink inspector' and the title for the Expansible Panel could be called 'Messages monitor' for example (unless we are planning to implement configurations on this section. On this case the title is nice).
2 and 4- The top and bottom line for the expansible panel can be disabled using the appropriate props.
3- This right element (message values) can be hidden while no message is selected.

image

@rafaellehmkuhl
Copy link
Member Author

Nice! Very handy tool to have on Cockpit!

Some things to adjust on the UI:

1- If we're not configuring MavLink into it, but monitoring, this could be called 'Mavlink inspector' and the title for the Expansible Panel could be called 'Messages monitor' for example (unless we are planning to implement configurations on this section. On this case the title is nice). 2 and 4- The top and bottom line for the expansible panel can be disabled using the appropriate props. 3- This right element (message values) can be hidden while no message is selected.

Nice! Will do the changes!

This tool can help users on debugging of MAVLink related problems.

It allows the user to see the messages that are being received by Cockpit, as well as the ones being sent.

This was already useful before being merged on a situation where we needed to know if the proper `MANUAL_CONTROL` messages were being sent.
@ArturoManzoli ArturoManzoli merged commit ba35245 into bluerobotics:master Jan 15, 2025
11 checks passed
@rafaellehmkuhl rafaellehmkuhl deleted the add-mavlink-inspector branch January 15, 2025 12:42
@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Jan 20, 2025
@ES-Alexander ES-Alexander added the docs-in-progress Included in an open docs PR label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-in-progress Included in an open docs PR docs-needed Change needs to be documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button commands maybe leaking? We need manual-control logs!
3 participants