Skip to content

Commit

Permalink
REMOVE: saco las migraciones que crean las tablas de veriones.
Browse files Browse the repository at this point in the history
si no las sacas da error cuando queres correr las migraciones desde la version cero
  • Loading branch information
Olvap committed Feb 28, 2012
1 parent 6c4c03a commit fd52968
Show file tree
Hide file tree
Showing 15 changed files with 22 additions and 288 deletions.
11 changes: 0 additions & 11 deletions db/migrate/20110117205638_add_versionate_programas.rb

This file was deleted.

11 changes: 0 additions & 11 deletions db/migrate/20110117205710_add_versionate_thabitacions.rb

This file was deleted.

11 changes: 0 additions & 11 deletions db/migrate/20110117205726_add_versionate_reservas.rb

This file was deleted.

11 changes: 0 additions & 11 deletions db/migrate/20110117205757_add_versionate_monedas.rb

This file was deleted.

11 changes: 0 additions & 11 deletions db/migrate/20110117205849_add_versionate_pasajeros.rb

This file was deleted.

11 changes: 0 additions & 11 deletions db/migrate/20110117210004_add_versionate_tdocs.rb

This file was deleted.

11 changes: 0 additions & 11 deletions db/migrate/20110131051950_add_versionate_entidads.rb

This file was deleted.

11 changes: 0 additions & 11 deletions db/migrate/20110131181802_add_versionate_tdepositos.rb

This file was deleted.

9 changes: 4 additions & 5 deletions db/migrate/20110428193116_add_boucher_to_reservas.rb
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
class AddBoucherToReservas < ActiveRecord::Migration
def self.up
add_column :reservas, :boucher, :date
add_column :reserva_versions, :boucher, :date
#add_column :reservas, :boucher, :date
#add_column :reserva_versions, :boucher, :date
end

def self.down
remove_column :reservas, :boucher
remove_column :reserva_versions, :boucher
#remove_column :reservas, :boucher
#remove_column :reserva_versions, :boucher
end
end

5 changes: 2 additions & 3 deletions db/migrate/20110506124940_rename_boucher_to_voucher.rb
Original file line number Diff line number Diff line change
@@ -1,12 +1,11 @@
class RenameBoucherToVoucher < ActiveRecord::Migration
def self.up
rename_column :reservas, :boucher, :voucher
rename_column :reserva_versions, :boucher, :voucher
#rename_column :reserva_versions, :boucher, :voucher
end

def self.down
rename_column :reservas, :voucher, :boucher
rename_column :reserva_versions, :voucher, :boucher
#rename_column :reserva_versions, :voucher, :boucher
end
end

5 changes: 2 additions & 3 deletions db/migrate/20110513182028_add_money_to_reservas.rb
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
class AddMoneyToReservas < ActiveRecord::Migration
def self.up
[:reservas, :reserva_versions].each do |tabla|
[:reservas].each do |tabla|
change_table tabla do |t|
t.integer :total_cents
t.string :total_currency, :limit => 3
Expand All @@ -16,7 +16,7 @@ def self.up
end

def self.down
[:reservas, :reserva_versions].each do |tabla|
[:reservas].each do |tabla|
change_table tabla do |t|
t.remove :total_cents
t.remove :total_currency
Expand All @@ -31,4 +31,3 @@ def self.down
end
end
end

9 changes: 4 additions & 5 deletions db/migrate/20110623174646_add_liquidada_to_reservas.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,14 @@ class AddLiquidadaToReservas < ActiveRecord::Migration
def self.up
add_column :reservas, :liquido_agencia, :boolean, :default => false
add_column :reservas, :liquido_operadora, :boolean, :default => false
add_column :reserva_versions, :liquido_agencia, :boolean, :default => false
add_column :reserva_versions, :liquido_operadora, :boolean, :default => false
#add_column :reserva_versions, :liquido_agencia, :boolean, :default => false
#add_column :reserva_versions, :liquido_operadora, :boolean, :default => false
end

def self.down
remove_column :reservas, :liquido_operadora
remove_column :reservas, :liquido_agencia
remove_column :reserva_versions, :liquido_operadora
remove_column :reserva_versions, :liquido_agencia
#remove_column :reserva_versions, :liquido_operadora
#remove_column :reserva_versions, :liquido_agencia
end
end

8 changes: 4 additions & 4 deletions db/migrate/20110727233516_add_comision_tarifa.rb
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
class AddComisionTarifa < ActiveRecord::Migration
def self.up
add_column :reservas, :comision, :integer
add_column :reserva_versions, :comision, :integer
# add_column :reserva_versions, :comision, :integer
add_column :reservas, :habitaciones, :integer
add_column :reserva_versions, :habitaciones, :integer
# add_column :reserva_versions, :habitaciones, :integer

end

def self.down
remove_column :reservas, :comision
remove_column :reservas, :habitaciones
remove_column :reserva_versions, :comision
remove_column :reserva_versions, :habitaciones
# remove_column :reserva_versions, :comision
# remove_column :reserva_versions, :habitaciones
end
end
5 changes: 2 additions & 3 deletions db/migrate/20120123135350_remove_fecha_from_reservas.rb
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
class RemoveFechaFromReservas < ActiveRecord::Migration
def self.up
[:reservas, :reserva_versions].each do |table_name|
[:reservas].each do |table_name|
remove_column table_name, :fecha
end
end

def self.down
[:reservas, :reserva_versions].each do |table_name|
[:reservas].each do |table_name|
add_column table_name, :fecha, :date
end
end
end

Loading

5 comments on commit fd52968

@eloyesp
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otra opció sería modificarlas para que solo creen la tabla (cuestión de que las migraciones funcionen tanto desde 0 como desde dónde están actualmente en producción). Es un problema este, yo lo plantié en un (issue de rails) rails/rails#5077, pero todavía no me dijeron nada.

@olvap
Copy link
Member

@olvap olvap commented on fd52968 Feb 29, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cual sería la ventaja de que esten? yo prefiero que halla pocos sobre todo si vamos a instalarlo en otro lado.

@eloyesp
Copy link
Member

@eloyesp eloyesp commented on fd52968 Mar 1, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La ventaja de que estén es que la aplicación que está instalada en producción podría seguir andando (sin necesidad de hacer rollbacks de migraciones o dejar migraciones por la mitad).
Por otro lado, no tiene importancia si las migraciones se agregan, porque si instalamos una aplicación nueva, podríamos utilizar el schema (que es lo que hay que hacer), y las migraciones no deberían correr en ningún momento. (ya que se darían por corridas por rake db:setup), las migraciones no se cargan en la aplicación así que no se hace más lento de ningún modo.

@olvap
Copy link
Member

@olvap olvap commented on fd52968 Mar 1, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok entonces. haces el cambio?

@eloyesp
Copy link
Member

@eloyesp eloyesp commented on fd52968 Mar 2, 2012 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.