fix(web): Use GainNode for volume control to fix Safari compatibility#1978
Open
Szymon-Gesicki wants to merge 1 commit intobluefireteam:mainfrom
Open
fix(web): Use GainNode for volume control to fix Safari compatibility#1978Szymon-Gesicki wants to merge 1 commit intobluefireteam:mainfrom
Szymon-Gesicki wants to merge 1 commit intobluefireteam:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When an
HTMLAudioElementis connected to the Web Audio API viacreateMediaElementSource(), Safari ignores theHTMLMediaElement.volumeproperty — the audio is routed through the Web Audio API graph and Safari expects volume to be controlled within that graph.Previously, volume was set directly on the
HTMLAudioElement.volumeproperty, which only worked on Chrome (Chrome honorselement.volumeeven after connecting to Web Audio API).This PR replaces
HTMLAudioElement.volumewith aGainNodeinserted into the Web Audio API processing chain:Before:
MediaElementSource → StereoPanner → Destination(volume viaelement.volume)After:
MediaElementSource → GainNode → StereoPanner → Destination(volume viagainNode.gain.value)This is the standard pattern recommended by MDN for controlling volume in Web Audio API.
How to reproduce:
Why
GainNodeis the correct fix:Checklist
fix:,feat:,refactor:,docs:,chore:,test:,ci:etc).///, where necessary.Breaking Change
Related Issues