Fix re-compilation issue in case of nested projects #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem:
Say we have the followign project structure:
/root_project
rebar.config
/apps
/app1
/rebar.config <- uses pc
and app1 needs to build a NIF library.
First trigger of `rebar3 compile` from /root_project builds NIF library
correctly.
When `rebar3 compile` is triggered the second time, the NIF library
will not be re-compiled even if its source files change, because
the paths to the NIF sources and NIF objects are relative to /app1,
while actual cwd is /root_project in this case.
The same error leads to incorrect behavior when cleaning the project
(nothing gets cleaned up).
Solution:
Append project root to source and object paths before checking
their last modification times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Say we have the following project structure:
and app1 needs to build a NIF library.
First trigger of
rebar3 compilefrom /root_project builds NIF library correctly.When
rebar3 compileis triggered the second time, the NIF library will not be re-compiled even if its source files change, because the paths to the NIF sources and NIF objects are relative to /app1, while actual cwd is /root_project in this case.The same error leads to incorrect behavior when cleaning the project (nothing gets cleaned up).
Solution:
Append project root to source and object paths before checking their last modification times.