Feature/update from template

[blooop]

Summary by Sourcery

Simplify the Claude Code devcontainer feature by relying on the Node.js feature via installsAfter, improving home directory resolution, and tightening devcontainer setup defaults.

Bug Fixes:

• Add defensive resolution and clear error handling for the target user home directory when creating Claude configuration directories.
• Ensure an .ssh directory with correct permissions exists for the vscode user to support SSH config mounts.

Enhancements:

• Remove in-script package manager and Node.js installation logic in favor of requiring Node.js via the devcontainer feature dependency mechanism.
• Improve CLI installation checks so Claude Code installation is idempotent and fails early if Node.js/npm are unexpectedly missing.
• Clarify documentation around automatic Node.js installation, container user assumptions, and known runArgs=host issues.
• Set a default PIXI_VERSION in the devcontainer Dockerfile to stabilize Pixi installation.

[sourcery-ai]

Reviewer's Guide

Refactors the claude-code devcontainer feature to rely on the devcontainer Node.js feature instead of doing in-script package management, hardens home-directory handling, tweaks documentation to match the new behavior, pins the Pixi version, and prepares the devcontainer for SSH config mounts.

Sequence diagram for updated claude-code devcontainer feature installation

sequenceDiagram
    participant DevcontainerEngine
    participant NodeFeature as Node_feature
    participant ClaudeFeature as Claude_code_feature
    participant Shell as install_sh
    participant Npm as npm_registry

    DevcontainerEngine->>NodeFeature: Build step: install Node_feature
    NodeFeature-->>DevcontainerEngine: Node.js and npm installed

    DevcontainerEngine->>ClaudeFeature: Build step: activate claude-code feature
    ClaudeFeature->>Shell: Execute install.sh main

    Shell->>Shell: Print feature activation banner
    Shell->>Shell: Check command node
    Shell->>Shell: Check command npm
    alt Node or npm missing
        Shell->>DevcontainerEngine: Print error about missing Node.js feature
        Shell-->>DevcontainerEngine: Exit 1
    else Node and npm available
        Shell->>Shell: Check command claude
        alt claude already installed
            Shell->>Shell: Print existing version
        else claude not installed
            Shell->>Npm: npm install -g @anthropic-ai/claude-code
            Npm-->>Shell: Package installed globally
        end
        Shell->>Shell: create_claude_directories
        Shell-->>ClaudeFeature: Installation and configuration complete
    end

    ClaudeFeature-->>DevcontainerEngine: Feature activation finished

Loading

Flow diagram for robust target home directory resolution

flowchart TD
    Start([Start create_claude_directories]) --> SetUser[Set target_user = _REMOTE_USER or vscode]
    SetUser --> SetHome[Set target_home = _REMOTE_USER_HOME or /home/target_user]
    SetHome --> CheckHome{Does target_home exist?}

    CheckHome -->|Yes| UseTargetHome[Use target_home]
    UseTargetHome --> End([Done])

    CheckHome -->|No| CheckEnvHome{Is HOME set and exists?}
    CheckEnvHome -->|Yes| UseEnvHome[Warn and set target_home = HOME]
    UseEnvHome --> End

    CheckEnvHome -->|No| CheckDefaultHome{Does /home/target_user exist?}
    CheckDefaultHome -->|Yes| UseDefaultHome[Warn and set target_home = /home/target_user]
    UseDefaultHome --> End

    CheckDefaultHome -->|No| Error[Print error about missing home dirs and exit 1]
    Error --> End

Loading

Flow diagram for Node.js requirement enforcement in install.sh

flowchart TD
    Start([Start main]) --> Banner[Print feature activation banner]
    Banner --> CheckNode{command -v node and npm}

    CheckNode -->|Missing| ErrorMsg[Print multi-line error
about required Node.js feature]
    ErrorMsg --> ExitError[exit 1]

    CheckNode -->|Present| CheckClaude{command -v claude}

    CheckClaude -->|Exists| PrintVersion[Print existing Claude CLI version]
    PrintVersion --> CreateDirs[Run create_claude_directories]
    CreateDirs --> End([Done])

    CheckClaude -->|Missing| InstallClaude[npm install -g @anthropic-ai/claude-code]
    InstallClaude --> CreateDirs
    CreateDirs --> End

Loading

File-Level Changes

Change	Details	Files
Simplified Claude Code feature install script to rely on pre-provisioned Node.js and improved robustness of user home directory resolution.	Removed custom package-manager and Node.js auto-installation logic from the install script, assuming Node.js is supplied via devcontainer features. Added an explicit check that node and npm are present, with a detailed troubleshooting message and early exit if they are not. Adjusted target user/home resolution for configuration directory creation, adding fallbacks to $HOME and /home/${target_user} with clear error messaging when no suitable home exists. Kept idempotent Claude CLI installation behavior but simplified the main() flow now that Node.js handling is externalized.	.devcontainer/claude-code/install.sh
Updated documentation for the claude-code feature to reflect automatic Node.js installation and clarified user/mount assumptions and known issues.	Renamed the setup section and removed the explicit Node.js feature recommendation in favor of explaining installsAfter-based installation. Clarified container user assumptions and how to configure mounts when the user differs from vscode. Removed the dedicated Node.js troubleshooting section and made minor copy/formatting fixes, including a corrected link reference description.	.devcontainer/claude-code/README.md
Pinned Pixi to a specific version and prepared the devcontainer for SSH configuration mounts.	Set a default PIXI_VERSION build-arg value to v0.62.2 for reproducible builds. Created the /home/vscode/.ssh directory with secure permissions to support SSH config volume mounts.	.devcontainer/Dockerfile
Synchronized devcontainer feature metadata, devcontainer configuration, and recommended VS Code extensions with the updated template.	Updated devcontainer-feature.json to integrate with the Node.js feature via installsAfter and align metadata with the template. Adjusted devcontainer.json to consume the updated claude-code feature and any new template defaults. Refreshed VS Code recommended extensions to match the latest template or feature requirements.	.devcontainer/claude-code/devcontainer-feature.json .devcontainer/devcontainer.json .vscode/extensions.json

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've found 2 issues

Prompt for AI Agents

Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `.devcontainer/claude-code/install.sh:53-64` </location>
<code_context>
+    # Be defensive: if the resolved home does not exist, fall back to $HOME,
</code_context>

<issue_to_address>
**suggestion:** Reconsider the fallback order for `target_home` to avoid surprising use of `$HOME` from a different user context.

The current order `_REMOTE_USER_HOME` → `$HOME` → `/home/${target_user}` means that in common devcontainer setups (script running as root with `HOME=/root` and `target_user=vscode`), `/root` is chosen over `/home/vscode` and then later `chown`ed to `vscode`. This is functional but surprising and can hide `_REMOTE_USER_HOME` misconfigurations. Consider preferring `/home/${target_user}` over `$HOME`, or validating that `$HOME` actually belongs to `target_user` before using it.

```suggestion
    local target_home="${_REMOTE_USER_HOME:-/home/${target_user}}"

    # Be defensive: if the resolved home does not exist, fall back to /home/${target_user},
    # then to $HOME. If neither is available, fail clearly.
    if [ ! -d "$target_home" ]; then
        if [ -d "/home/${target_user}" ]; then
            echo "Warning: target_home '$target_home' does not exist, falling back to /home/${target_user}" >&2
            target_home="/home/${target_user}"
        elif [ -n "${HOME:-}" ] && [ -d "$HOME" ]; then
            echo "Warning: target_home '$target_home' does not exist, falling back to \$HOME: $HOME" >&2
            target_home="$HOME"
        else
```
</issue_to_address>

### Comment 2
<location> `.devcontainer/claude-code/install.sh:112-115` </location>
<code_context>
-
-    # Install Claude Code CLI
-    # Check if already installed to make this idempotent
+    # Install Claude Code CLI (or verify it's already installed)
     if command -v claude >/dev/null; then
         echo "Claude Code CLI is already installed"
         claude --version
</code_context>

<issue_to_address>
**suggestion:** It may be useful to log Node.js/npm versions when present for easier debugging of CLI installation issues.

The earlier script printed `node --version` and `npm --version` when available, which is very helpful for diagnosing CLI install/runtime issues from CI or devcontainer logs. Please consider adding those version logs back, either in `main` before calling `install_claude_code` or inside `install_claude_code` itself.

Suggested implementation:

```
    # Install Claude Code CLI (or verify it's already installed)
    if command -v claude >/dev/null; then
        echo "Claude Code CLI is already installed"
        claude --version

        # Log Node.js and npm versions when available for easier debugging
        if command -v node >/dev/null; then
            echo "Node.js version: $(node --version)"
        else
            echo "Node.js is not installed or not on PATH"
        fi

        if command -v npm >/dev/null; then
            echo "npm version: $(npm --version)"
        else
            echo "npm is not installed or not on PATH"
        fi

```

If you also want Node.js/npm versions logged when the CLI is not yet installed (during the install path), mirror this version-logging block at the start of the installation function or in the script's `main` flow before `install_claude_code` is invoked. This ensures consistent diagnostic logging in both the "already installed" and "installing now" scenarios.
</issue_to_address>

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}