Airport Departure Project Finish #167
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swift-student
left a comment
swift-student
left a comment
There was a problem hiding this comment.
Very solid work, Norlan! You showed good understanding of the concepts from the third module. You should have no problems on the sprint challenge this weekend!
| } | ||
|
|
||
|
|
||
| } // END Class |
There was a problem hiding this comment.
Nice use of a comment to mark the end of your class.
| } | ||
|
|
||
|
|
||
| func passengerAlerts() { |
There was a problem hiding this comment.
Not a big deal, but this function has an extra level of indentation that isn't needed. The further you can keep stuff to the left, the less chance you have of line wrapping.
Comment on lines
+153
to
+167
| for departure in departureBoard.departureFlights { | ||
|
|
||
| var time = "" | ||
| var terminal = "" | ||
|
|
||
| if let departureTime = departure.departureTime { | ||
|
|
||
| time = dateFormat.string(from: departureTime) | ||
| } | ||
|
|
||
| if let terminalNum = departure.terminal { | ||
| terminal = "\(terminalNum)" | ||
| } | ||
| print("\nDestination \(departure.airport.destination) \nAirline: \(departure.airline) Flight: \(departure.flightNumber) Departure Time: \(time) Terminal: \(terminal) Flight Status: \(departure.fightStatus)") | ||
| } |
There was a problem hiding this comment.
Nice use of variables that are providing default values in case you can't unwrap the optionals. Very good approach.
Comment on lines
+239
to
+245
| // Number Formatter stretch! | ||
| let usCurrencyFormatter = NumberFormatter() | ||
| usCurrencyFormatter.numberStyle = .currency | ||
| if let price = usCurrencyFormatter.string(from: NSNumber(floatLiteral: tripOne)) | ||
| { | ||
| print(price) | ||
| } |
There was a problem hiding this comment.
Great work figuring out the number formatter!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@swift-student