Clayton wilkerson #1000
Clayton wilkerson #1000
Conversation
| @@ -0,0 +1,15 @@ | |||
| { | |||
There was a problem hiding this comment.
You can add this to your .gitignore file in the future to prevent it from being pushed to github
https://www.pluralsight.com/guides/how-to-use-gitignore-file
Not at all mandatory, but nice to know
| @@ -30,13 +30,22 @@ Edit this document to include your answers after each question. Make sure to lea | |||
|
|
|||
| 1. What is the DOM? | |||
|
|
|||
| Document object module: the representation of the content from html, css, and js. | |||
| 3. What is an event listener? | ||
|
|
||
| A way to track events and controll what happens after an event is triggered |
There was a problem hiding this comment.
event listeners are functions that execute when a relevant event fires
| 4. Why would we convert a NodeList into an Array? | ||
|
|
||
| Nodelist do not have the same methods as an array, sometimes you might want to apply an array method to a nodelist. |
| .then((res) => { | ||
| console.log ("Res: ", res) | ||
| articlesArray = res.data.articles; | ||
| let javascriptArt = articlesArray.javascript; |
There was a problem hiding this comment.
You can loop through each of the topics (javascript, bootstrap, etc) using Object.entries
Here's a link explaining more. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/entries
This isn't something you'd be expected to know but it's a good coding style adjustment.
You can also read about how to use a for loop to accomplish the same thing https://stackoverflow.com/questions/684672/how-do-i-loop-through-or-enumerate-a-javascript-object#:~:text=You%20can%20use%20the%20for,t%20come%20from%20the%20prototype.&text=Using%20the%20new%20Object.
|
|
||
|
|
||
|
|
||
| function Cards(article) { |
There was a problem hiding this comment.
Since this function is being defined in the global scope, it should be aligned with the axios.get( request and variable definitions above. Otherwise it looks, at a glance, like this function is being defined inside the .catch() or .then() functions (which we wouldn't want).
Summary: this shouldn't be indented.
| @@ -11,4 +11,27 @@ | |||
| // Use your function to create a header | |||
| // and append it to the DOM inside the div.header-container | |||
|
|
|||
| function Header() {} | |||
| function Header(date,title,temp) { | |||
| let header0 = document.createElement('div'); | |||
There was a problem hiding this comment.
I would recommend using const here because you aren't re-assigning any of these objects, you are only changing their attribute values.
Not something you are expected to know but it's good coding practice!
There was a problem hiding this comment.
I've developed a bad habit of just using let. I'll practice being cognizant of when to use each.
Kalina is creating this pull request because Clayton's PR accidentally compared his master branch rather than claayton-wilkerson branch