Skip to content

Conversation

@LisaCee
Copy link

@LisaCee LisaCee commented Mar 20, 2018

No description provided.

@wlharvey4
Copy link

Lisa-
I downloaded your app, installed dependencies, started it with yarn start, and it worked perfectly.

I reviewed your code. I can make these little suggestions:

App.js: be sure to make it a habit to wrap all returns in parentheses; your code will almost always work without parentheses, but sometimes you will get warnings and errors that become hard to debug, and adding the parentheses will never cause any problems and will always make your code easier to read. Also, make it a habit to avoid spaces in your props calls, and include a space prior to the final />, like so:

return (<MoviesList movies={this.state.movies} />);

These are how you will see professional React code written, and they are designed to reduce errors and make your code easier to read. The final space at the end is also designed to done as a habit, as sometimes not doing can again cause warnings and errors to appear that are hard to debug.

MoviesList.js: You have wrapped the return statement in parentheses, which is good. I would recommend placing each <ul> and </ul> on separate lines, and indenting its children, which in this case is the map function.

Other than those little details, which are designed to take your coding to the next level, you did great on this project.

Wesley

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants