-
Notifications
You must be signed in to change notification settings - Fork 177
Initial commit: Added Trello URL in README.md #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Initial commit: Added Trello URL in README.md #128
Conversation
Added Trello URL in README.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tsai, truly awesome job with this project. You did a great job documenting your code with frequent, detailed commits and adding your trello link. You also thought deeply about how to implment various parts of this project. Great work. One thing I suggest is to format your PRs in the form "FirstName LastName - Name-Of-Project" to make it easier for your PM to find. Overall, great work!
| - [ ] Share your board with the project manager that has been assigned to you. If you have not been assigned yet, reach out to your lead PM for guidance | ||
| - [ ] Add your Trello URL to your project's README.md file. Commit the change, push it to your repository & submit a pull request | ||
|
|
||
| https://trello.com/b/6Sp67zaD/lambdamud-tsai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good that you put your trello link in here. It's a small thing but a lot of students forget to do this, but it's really important for communicating your work so great job.
| path('admin/', admin.site.urls), | ||
| path('api/', include('api.urls')), | ||
| path('api/adv/', include('adventure.urls')), | ||
| re_path(r'^api-token-auth/', views.obtain_auth_token) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice how you implemented an authentication route here.
| player_uuid = player.uuid | ||
| player_id = player.id | ||
| data = json.loads(request.body) | ||
| message = data['message'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a small thing, but have you thought about how you might handle the case where a user submits a blank message or a malicious code? It's definitely stretch but it could interesting to think about.
Trello Set Up:
backlog,To Do,In Progress, andDoneTo Dolist with the MVP features listed belowbackloglist with all the extra features listed belowhttps://trello.com/b/6Sp67zaD/lambdamud-tsai
MVP Features:
Client
saycommand to say things that other people in the room will see (server implementation incomplete)p-channel-<uuid>broadcastevents and display the messages to the playerServer
saywhich broadcasts a message to other players in the current roomGeneral