Skip to content

Conversation

@kinghuthman
Copy link

No description provided.

Copy link

@decagondev decagondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

Huthman. Your overall code base looks clean and well written. Your workflow is fluid and you have really done a good job of decomposition in this project. You have shown an understanding of the subject matter and implemented the overall project in a clean manner. You have also deployed the projects back and front end.

Breakdown

  • You have got MVP complete and then some.
  • your work is of good quality and you have really made this lambdaMUD your own.
  • You have added links in to the deployments
  • kept your commits clean and your git workflow granular and regular

Conclusions

Huthman. You have shown a good grasp of the material for this sprint and it has been a pleasure to install it locally and do a review over it. The only thing that I did not have was the login details to the API and deployed stuff. I also had to use my own API and secret keys etc to test it locally. that in itself if not a bad thing but it added a layer of complexity to the review. but Keep up the good work Huthman 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants