Harden --locals against trashed memory
#194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godlygeek
force-pushed
the
handle_trashed_locals
branch
from
0c7a734 to
db11510
Compare
godlygeek
commented
Aug 1, 2024
godlygeek
force-pushed
the
handle_trashed_locals
branch
from
db11510 to
6721256
Compare
When attempting to produce a repr for local variables, attempt to cope better with trashed memory: - Use "<invalid object at 0x1234>" as the repr of a `PyObject*` pointing directly at invalid memory, or one whose `ob_type` points at invalid memory. - Use "<list object at 0x1234>" as, for instance, the repr of a list containing an invalid `ob_items` pointer. More generally, use this for any object where we can determine the type, but generating the repr according to that type's rules fails due to accessing unmapped memory. Test this with some ctypes abuse. Signed-off-by: Matt Wozniski <[email protected]>
godlygeek
force-pushed
the
handle_trashed_locals
branch
from
6721256 to
456f12b
Compare
pablogsal
reviewed
Aug 1, 2024
pablogsal
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to produce a repr for local variables, attempt to cope
better with trashed memory:
PyObject*pointingdirectly at invalid memory, or one whose
ob_typepoints at invalidmemory.
invalid
ob_itemspointer. More generally, use this for any objectwhere we can determine the type, but generating the repr according to
that type's rules fails due to accessing unmapped memory.
Test this with some ctypes abuse.