Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add a tutorial for pystack remote - prime example #180

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

gwen-sarapata
Copy link
Contributor

No description provided.

@gwen-sarapata gwen-sarapata force-pushed the main branch 2 times, most recently from 851de44 to cc089b8 Compare May 20, 2024 22:46
@godlygeek godlygeek changed the title Add tutorial exercise 2 to find a prime number using a random number docs: Add a tutorial for pystack remote May 21, 2024
@sarahmonod sarahmonod changed the title docs: Add a tutorial for pystack remote docs: Add a tutorial for pystack remote - prime example May 21, 2024
@sarahmonod sarahmonod changed the base branch from main to tutorial May 21, 2024 15:56
@gwen-sarapata gwen-sarapata marked this pull request as ready for review May 22, 2024 20:49
@godlygeek godlygeek changed the base branch from tutorial to main July 23, 2024 22:38
Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! I've made some small tweaks to wording here and there, and restructured the layout of the tutorial to match the layout of the deadlock example (in particular, I dropped the solution file - it didn't make much sense to have it, since it only contains a one-line change, and it's easy to forget that we've got two copies and only modify one. They were already out of sync when I started reviewing!)

I kept all of the meat of this example the same, though, and I think it's a wonderful example full of misdirection that leads people away from the actual bug.

Thanks for the contribution, @gwen-sarapata!

@godlygeek godlygeek merged commit 2657eb6 into bloomberg:main Jul 23, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants