Disable attach tests in cibuildwheel #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests have broken because of changes to the GitHub runners. The old debuggers being installed in the containers are not compatible with the new Linux kernel being used by the runners. Rather than spend a bunch of effort to get this working, we'll just disable these tests in those environments. Note that we still exercising attaching with both debuggers in other workflows: the `test_with_coverage` workflow tests both gdb and lldb on glibc, and the `test_on_alpine` workflow tests both gdb and lldb on musl libc. Signed-off-by: Matt Wozniski <[email protected]>
We added the "Build and test wheels" job as a required check to our CI in order to avoid needing to list every possible matrix job as required, but this didn't actually work as intended: the job never failed, it always either passed or was skipped, and GitHub doesn't count a skipped job as a failing check. Work around this with a different approach: ensure that this job always runs, and succeeds if and only if all of its dependencies succeeded. Signed-off-by: Matt Wozniski <[email protected]>
pablogsal
approved these changes
Aug 21, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #670 +/- ##
==========================================
- Coverage 93.00% 92.97% -0.03%
==========================================
Files 94 94
Lines 11445 11445
Branches 2114 2114
==========================================
- Hits 10644 10641 -3
- Misses 801 804 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable the
memray attachtests in cibuildwheel. These tests have broken because of changes to the GitHub runners. The old debuggers being installed in the containers are not compatible with the new Linux kernel being used by the runners. Rather than spend a bunch of effort to get this working, we'll just disable these tests in those environments.Note that we still exercising attaching with both debuggers in other workflows: the
test_with_coverageworkflow tests both gdb and lldb on glibc, and thetest_on_alpineworkflow tests both gdb and lldb on musl libc.Additionally, ensure "Build and test wheels" can fail. We added the "Build and test wheels" job as a required check to our CI in order to avoid needing to list every possible matrix job as required, but this didn't actually work as intended: the job never failed, it always either passed or was skipped, and GitHub doesn't count a skipped job as a failing check.
Work around this with a different approach: ensure that this job always runs, and succeeds if and only if all of its dependencies succeeded.