Skip to content

Add cdb2api unread data test #5593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add cdb2api unread data test #5593

wants to merge 1 commit into from
+89 −4

Conversation

@chands10
Copy link
Contributor

@chands10 chands10 commented Nov 24, 2025 •
edited
Loading

/adhoc-test api_tst

roborivers
roborivers approved these changes Nov 24, 2025
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
cdb2api_tests

roborivers
roborivers approved these changes Nov 24, 2025
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
cdb2api_tests

@chands10 chands10 marked this pull request as draft November 24, 2025 19:58
roborivers
roborivers suggested changes Nov 24, 2025
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

@chands10 chands10 marked this pull request as ready for review November 24, 2025 20:18
roborivers
roborivers approved these changes Nov 24, 2025
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
cdb2api_tests

@chands10 chands10 marked this pull request as draft November 24, 2025 20:35
@chands10 chands10 force-pushed the unread_test branch 4 times, most recently from 4a69458 to 9d040bc Compare November 25, 2025 18:52
roborivers
roborivers approved these changes Dec 1, 2025
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
cdb2api_tests

@chands10 chands10 force-pushed the unread_test branch 3 times, most recently from 75b4bd5 to 9780286 Compare December 1, 2025 21:34
@chands10 chands10 marked this pull request as ready for review December 1, 2025 21:34
roborivers
roborivers approved these changes Dec 1, 2025
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
api_tests

roborivers
roborivers approved these changes Dec 1, 2025
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

roborivers
roborivers approved these changes Dec 2, 2025
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
apitest

@chands10
Add cdb2api unread data test
f65e968 
Signed-off-by: Salil Chandra <[email protected]>
chands10
chands10 commented Dec 2, 2025
View reviewed changes
tests/api_tst.test/runit

cfg=$DBDIR/comdb2db.cfg
echo 'comdb2_feature:discard_unread_socket_data=on' >> ${cfg}
${TESTSBUILDDIR}/cdb2api_unread_data ${DBNAME}
Copy link
Contributor Author

@chands10 chands10 Dec 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test name (apitst) must be at most 6 letters otherwise sockpool will not be used lol

roborivers
roborivers approved these changes Dec 2, 2025
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

roborivers
roborivers approved these changes Dec 2, 2025
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.

roborivers
roborivers suggested changes Dec 2, 2025
View reviewed changes
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

mohitkhullar
mohitkhullar approved these changes Dec 2, 2025
View reviewed changes
Copy link
Contributor

@mohitkhullar mohitkhullar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mohitkhullar mohitkhullar mohitkhullar approved these changes

+1 more reviewer

@roborivers roborivers roborivers requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chands10 @mohitkhullar @roborivers