cdb2api: fixing client invalid response type error #5483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roborivers
suggested changes
Oct 13, 2025
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
logfill_logput_window_generated
riverszhang89
force-pushed
the
try_ssl_backout_rebase
branch
from
54b1325 to
1d886e0
Compare
Signed-off-by: mdouglas47 <[email protected]>
Signed-off-by: mdouglas47 <[email protected]>
Morgan demonstrated that if SSL is enabled, when the server experiences a high connection rate and is slow to complete SSL handshakes, a client may mistake OpenSSL's hello packet for a plaintext server response. This patch fixes it. Signed-off-by: Rivers Zhang <[email protected]>
riverszhang89
force-pushed
the
try_ssl_backout_rebase
branch
from
1d886e0 to
08ad3b2
Compare
roborivers
approved these changes
Nov 5, 2025
roborivers
left a comment
roborivers
left a comment
There was a problem hiding this comment.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
The first 10 failing tests are:
trans [setup core dumped]
sc_redo [core dumped]
logfill_logput_window_generated
upsert
undrained_connection
undrained_connection_nossl_generated
sc_transactional_rowlocks_generated
truncatesc_offline_generated
insert_lots_ssl_generated
insert_lots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Morgan demonstrated that if SSL is enabled, when the server experiences a high connection rate and is slow to complete SSL handshakes, a client may mistake OpenSSL's hello packet for a plaintext server response.
This patch fixes it.