Merge pull request #1481 from blockchain-certificates/chore/bundle-stats

perf(bundle): split download pdf logic
blockchain-certificates · Nov 8, 2023 · 7e87075 · 7e87075
2 parents 048c425 + b0ea582
commit 7e87075
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/bundle-stats.html b/bundle-stats.html
diff --git a/src/actions/downloadPDF.ts b/src/actions/downloadPDF.ts
@@ -1,4 +1,3 @@
-import domain from '../domain';
 import updateIsGeneratingPDF from './updateIsGeneratingPDF';
 import {
   getCertificateTitle,
@@ -20,6 +19,8 @@ export default function downloadPDF () {
   return async function (dispatch: Dispatch, getState: () => BlockcertsVerifierState): Promise<void> {
     const state = getState();
 
+    const { default: downloadPDF } = await import('../domain/certificates/useCases/downloadPDF');
+
     const contentType: CONTENT_TYPES = getDisplayContentType(state);
     const contentEncoding: string = getDisplayContentEncoding(state);
     const content: string = getDisplayContent(state);
@@ -35,7 +36,7 @@ export default function downloadPDF () {
 
     dispatch(updateIsGeneratingPDF(true));
 
-    await domain.certificates.downloadPDF({
+    await downloadPDF({
       contentType,
       contentEncoding,
       content,

diff --git a/src/domain/certificates/useCases/index.ts b/src/domain/certificates/useCases/index.ts
@@ -1,6 +1,6 @@
 import displayHtmlHasNoWidthConstraint from './displayHtmlHasNoWidthConstraint';
 import download from './download';
-import downloadPDF from './downloadPDF';
+// import downloadPDF from './downloadPDF'; // removed to prefer async import
 import initializeVerificationSteps from './initializeVerificationSteps';
 import retrieve from './retrieve';
 import read from './read';
@@ -10,7 +10,6 @@ import isPathToCertificateValidURI from './isPathToCertificateValidURI';
 export {
   displayHtmlHasNoWidthConstraint,
   download,
-  downloadPDF,
   initializeVerificationSteps,
   retrieve,
   read,