Skip to content

Fix handling of numbers that convert to negative longs #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix handling of numbers that convert to negative longs #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...a-core/bigdata-rdf/src/java/com/bigdata/rdf/internal/InlineUnsignedIntegerURIHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,9 @@ public static AbstractLiteralIV createInlineIV(final BigInteger value) {
*/
@SuppressWarnings("rawtypes")
public static AbstractLiteralIV createInlineIV(final long value) {
if (value < 0L) {
return new XSDUnsignedLongIV(value + Long.MIN_VALUE);
}
if (value < 256L) {
return new XSDUnsignedByteIV((byte) (value + Byte.MIN_VALUE));
}
Expand Down
3 changes: 2 additions & 1 deletion bigdata-rdf-test/src/test/java/com/bigdata/rdf/store/TestInlineURIs.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/**
Copyright (C) SYSTAP, LLC DBA Blazegraph 2006-2016. All rights reserved.
Copyright (C) SYSTAP, LLC DBA Blazegraph 2006-2016. All rights reserved.

Contact:
SYSTAP, LLC DBA Blazegraph
Expand Down Expand Up @@ -246,6 +246,7 @@ public void testUnsignedInteger() throws Exception {
UNSIGNED_INT_NAMESPACE + Short.MAX_VALUE, true,//
UNSIGNED_INT_NAMESPACE + Integer.MAX_VALUE, true,//
UNSIGNED_INT_NAMESPACE + Long.MAX_VALUE, true,//
UNSIGNED_INT_NAMESPACE + "12148449524915690527", true,//
UNSIGNED_INT_NAMESPACE + "19223372036854775807", true,//
UNSIGNED_INT_NAMESPACE + "foo", false);
}
Expand Down