refactor!: possible changes to be made #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asppsa
force-pushed
the
commonjs
branch
2 times, most recently
from
684976e to
408455b
Compare
asppsa
commented
Jul 25, 2024
Comment on lines
-3237
to
+3190
| var mixingType = animationState.getMixingTransform(this.name); | ||
| var mixingType = animationState.getMixingTransform(name); |
asppsa
commented
Jul 25, 2024
| this.scaleMode = 1; | ||
| this.fixedRotation = false; |
asppsa
commented
Jul 25, 2024
| for (var index in this._animationDataList) { | ||
| if (!this._animationDataList.hasOwnProperty(index)) continue; | ||
| for (var index=0; index < this._animationDataList.length; index++) { |
There was a problem hiding this comment.
These hasOwnProperty checks were added in cfaaa8b
asppsa
commented
Jul 25, 2024
asppsa
commented
Jul 25, 2024
asppsa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This compares the 2.4.1-derived code with some patches that were floating around internally.