add borough to hint #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hey @mrichins, thanks for opening this PR (and fixing the filename case issue of the script)! Though you're not the first person to have made this suggestion, unfortunately, I'm sorry and I'm going to decline this PR. To me, a big part of the challenge of this game is having to figure out which train(s) serve each station, and having the borough included in my opinion, makes the game too easy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Big fan of what you were doing here and have been playing with friends almost every day.
One thing we have had trouble with is knowing the difference between stations that are totally different boroughs but share a name (i.e. there are 3 7th Avenue stations) I just made a quick change for you to check out how the game feels after revealing the boros of the origin and destination in the hint.
I also noticed a small linux compatibility bug (probably works in OSX because of APFS) where you look for a lowercase
stations.csvbut the default filename (and instructions) are looking forStations.csvAnyway, keep up the good work and please let me know if theres any way I can help out whenever!